Fix root disk resize issue when service offering has no root disk size specified by sureshanaparti · Pull Request #9428 · apache/cloudstack

sureshanaparti · 2024-07-22T12:22:15Z

Description

This PR fixes root disk resize issue when service offering has no root disk size specified.

Issue: During root disk resize, the root disk size details are checked in a different service offering (lookup with disk offering id of the root disk in service offering view).

This addresses #9380

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested the root resize with service offering having root disk size set.

How did you try to break this feature and the system with this change?

…k size, only allow through service offering change

sureshanaparti · 2024-07-22T12:22:55Z

@blueorangutan package

blueorangutan · 2024-07-22T12:24:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-07-22T12:30:34Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.07%. Comparing base (54c8b71) to head (413edfe).
Report is 45 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9428      +/-   ##
============================================
- Coverage     15.07%   15.07%   -0.01%     
- Complexity    11169    11170       +1     
============================================
  Files          5405     5405              
  Lines        472677   472676       -1     
  Branches      60049    58516    -1533     
============================================
- Hits          71269    71268       -1     
  Misses       393479   393479              
  Partials       7929     7929

Flag	Coverage Δ
uitests	`4.27% <ø> (ø)`
unittests	`15.79% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-07-22T13:23:24Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10437

sureshanaparti · 2024-07-22T18:03:16Z

@blueorangutan test

blueorangutan · 2024-07-22T18:04:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

sureshanaparti · 2024-07-22T18:04:18Z

@blueorangutan package

blueorangutan · 2024-07-22T18:06:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-22T19:12:39Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10440

sureshanaparti · 2024-07-22T19:14:01Z

@blueorangutan test

blueorangutan · 2024-07-22T19:16:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland

clgtm

blueorangutan · 2024-07-23T09:39:33Z

[SF] Trillian test result (tid-10943)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50252 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9428-t10943-kvm-centos7.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

harikrishna-patnala

code LGTM. infact assumption of finding service offering with disk offering id is not valid now as we have decoupled service and disk offerings.

shwstppr

code lgtm

vishesh92

lgtm

yadvr · 2024-09-05T17:22:19Z

@vishesh92 can you confirm if you'd finished manual QA on this? thanks.

vishesh92 · 2024-09-05T17:27:58Z

@vishesh92 can you confirm if you'd finished manual QA on this? thanks.

I had an offline discussion with @sureshanaparti and there was some confusion about the expected behaviour.

As of now, if disk size is set in the offering and disk offering's size strictness is disabled, I am not able to resize the disk.

vishesh92 · 2024-09-06T05:15:23Z

Had another discussion with @sureshanaparti . This is working as expected. Merging.

…k size, only allow through service offering change (apache#9428)

…of the root disk in service offering view (apache#9428) (apache#489) Issue: During root disk resize, the root disk size details are checked in a different service offering (looks up with disk offering id of the root disk in service offering view which is getting wrong service offering).

Fix root disk resize (don't allow) when service offering has root dis…

413edfe

…k size, only allow through service offering change

boring-cyborg bot added the component:storage label Jul 22, 2024

sureshanaparti requested review from DaanHoogland and harikrishna-patnala July 22, 2024 12:22

sureshanaparti linked an issue Jul 22, 2024 that may be closed by this pull request

Can not change size root disk instances #9380

Closed

apache deleted a comment from blueorangutan Jul 22, 2024

DaanHoogland approved these changes Jul 23, 2024

View reviewed changes

sureshanaparti requested review from shwstppr and vishesh92 July 23, 2024 11:14

harikrishna-patnala approved these changes Jul 24, 2024

View reviewed changes

shwstppr approved these changes Jul 24, 2024

View reviewed changes

yadvr added this to the 4.19.2.0 milestone Jul 29, 2024

sureshanaparti added the status:needs-testing label Aug 27, 2024

yadvr approved these changes Sep 5, 2024

View reviewed changes

sureshanaparti changed the title ~~Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change~~ Fix root disk resize (not allowed) when service offering has root disk size, only allowed through service offering change Sep 5, 2024

vishesh92 approved these changes Sep 5, 2024

View reviewed changes

sureshanaparti marked this pull request as draft September 5, 2024 09:53

yadvr removed the status:needs-testing label Sep 5, 2024

yadvr marked this pull request as ready for review September 5, 2024 17:22

vishesh92 merged commit ebaf064 into apache:4.19 Sep 6, 2024

vishesh92 deleted the root-disk-resize-validation-fix branch September 6, 2024 05:15

sureshanaparti mentioned this pull request Sep 6, 2024

Can not change size root disk instances #9380

Closed

sureshanaparti changed the title ~~Fix root disk resize (not allowed) when service offering has root disk size, only allowed through service offering change~~ Fix root disk resize issue when service offering has no root disk size specified Sep 6, 2024

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 10, 2024

Fix root disk resize (don't allow) when service offering has root dis…

151519a

…k size, only allow through service offering change (apache#9428)

nvazquez mentioned this pull request Mar 11, 2026

regression: disk offering strictness not honored when resizing root volume (4.22.0) #12099

Closed

Conversation

sureshanaparti commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Jul 22, 2024

Uh oh!

blueorangutan commented Jul 22, 2024

Uh oh!

codecov bot commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 22, 2024

Uh oh!

sureshanaparti commented Jul 22, 2024

Uh oh!

blueorangutan commented Jul 22, 2024

Uh oh!

sureshanaparti commented Jul 22, 2024

Uh oh!

blueorangutan commented Jul 22, 2024

Uh oh!

blueorangutan commented Jul 22, 2024

Uh oh!

sureshanaparti commented Jul 22, 2024

Uh oh!

blueorangutan commented Jul 22, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jul 23, 2024

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Sep 5, 2024

Uh oh!

vishesh92 commented Sep 5, 2024

Uh oh!

vishesh92 commented Sep 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sureshanaparti commented Jul 22, 2024 •

edited

Loading

codecov bot commented Jul 22, 2024 •

edited

Loading